Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Paperwork Prefabs #5265

Draft
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Dec 20, 2023

Feedback here so I see it faster: https://discord.com/channels/150315577943130112/1233574245418668042/1233574245418668042

About the pull request

Adds a bunch of forms that can be taken out of filing cabinets to be filled out. Makes use of paperwork much more practical, and as it's using HTML, significantly more customisable.

This PR has focused on Military Police and the Corporate Liaison, but the system is designed to be completely modular.

While I have thoroughly tested my system works the way I want it to, I would appreciate input on quality/efficiency improvement.

Explain why it's good for the game

QOL, I think it will encourage people to use paperwork a lot more. I particularly want to see Military Police using it more often particularly in regards to Appeals.

Testing Photographs and Procedure

Screenshots & Videos

There are a couple inconsistencies in the images below, but these have been corrected since.

image
image

Changelog

🆑
code: Reorganises how paperwork gets image references, and moves them to a new folder.
add: Added prefab paperwork forms for use by Military Police and the Corporate Liaison.
code: Changed the [logo] paperwork tag to [wy_bw]
imageadd: Added a dark background often used by staff faxes for easy referencing.
imageadd: Updated WY and USCM logos to higher quality versions.
code: Reorganises the fountain pen into a subtype of obj/item/tool/pen/multicolor to make the functionality usable in multiple pens.
add: Adds a provost pen, a variant of multicolor pen that can switch between Black, White, Orange, Blue, Green and Red. Intended for use in filling out MP forms.
/:cl:

@realforest2001 realforest2001 marked this pull request as draft December 20, 2023 22:35
@github-actions github-actions bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? Feature Feature coder badge labels Dec 20, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 25, 2023
Copy link
Contributor

github-actions bot commented Jan 2, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jan 2, 2024
@github-actions github-actions bot closed this Jan 10, 2024
@github-actions github-actions bot added the Code Improvement Make the code longer label Apr 26, 2024
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Apr 26, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@deathrobotpunch
Copy link
Contributor

one thing TG has done is making paperwork prefabs printable by the photocopier which would fit this perfectly

cm13-github added a commit that referenced this pull request Sep 10, 2024
cm13-github added a commit that referenced this pull request Sep 11, 2024
cm13-github added a commit that referenced this pull request Sep 11, 2024
cm13-github added a commit that referenced this pull request Sep 11, 2024
cm13-github added a commit that referenced this pull request Sep 12, 2024
cm13-github added a commit that referenced this pull request Sep 13, 2024
cm13-github added a commit that referenced this pull request Sep 14, 2024
cm13-github added a commit that referenced this pull request Sep 14, 2024
@deathrobotpunch
Copy link
Contributor

the new WY logo doesn’t look great

Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping lgtm

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Oct 17, 2024
@cmss13-ci
Copy link
Contributor

cmss13-ci bot commented Oct 27, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci bot added the Stale beg a maintainer to review your PR label Oct 27, 2024
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Oct 30, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Feature Feature coder badge Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Merge Conflict PR can't be merged because it touched too much code Sprites Remove the soul from the game. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants